London | May 2025 | Houssam Lahlah | Coursework/sprint 1 #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments to exclude instructional lines from execution
Updated age variable to let to allow incrementing its value.
Declare variable before using in template string.
Add comments explaining slice error and fix by converting number to string.
Fix invalid variable names by renaming to start with letters instead of numbers.
Add missing comma to replaceAll so the code runs smoothly.
Add detailed comments answering questions about movie length time calculation.
Add detailed comments explaining step-by-step price formatting from pence string.
… and store the ext part of the variable
cjyuan
reviewed
Jul 17, 2025
| @@ -4,3 +4,4 @@ count = count + 1; | |||
|
|
|||
| // Line 1 is a variable declaration, creating the count variable with an initial value of 0 | |||
| // Describe what line 3 is doing, in particular focus on what = is doing | |||
| // line 3 is increases the value of count by 1 and saves the updated value back into count variable. | |||
There was a problem hiding this comment.
Operation like count = count + 1 is very common in programming, and there is a programming term describing such operation.
Can you find out what one-word programming term describes the operation on line 3?
|
|
||
| 1. Math.random() | ||
|
|
||
| Returns a random decimal number between 0 and 1 but never gives 1.0. |
There was a problem hiding this comment.
We can also use the concise and precise interval notation to describe a range of values.
[,]=> inclusion(,)=> exclusion
For example, we can say, "Math.random()returns a random number in the interval[0, 1)"
Comment on lines
+25
to
+27
| // 5. Extracts the last two characters as the pence part. | ||
| // For "399", this is "99". | ||
| // Then pads the string on the right with zeros if it’s shorter than 2 characters (not needed here). |
There was a problem hiding this comment.
When you mentioned "not needed here", do you mean we can delete .padEnd(2, "0") at line 24?
Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LASTNAME | PROJ_NAME
I have tested my changes (where applicable)
My changes follow the style guide
My changes meet the requirements of this task
Changelist
key-exercise:
Practiced variable reassignment with count = count + 1
Extracted initials from full names using charAt(0)
Parsed file paths using slice() and lastIndexOf()
Explained how random numbers are generated with Math.random() and Math.floor()
mandatory-errors: Identified common learning mistakes (e.g., using const when let is needed)
mandatory-interpret: Interpreted JavaScript behaviors like console.log, prompt(), and variable hoisting
stretch-explore: Explored the Chrome DevTools Console and JavaScript built-in methods like alert(), prompt(), and typeof
Questions
Hello,
I’ve completed all parts of the Sprint 1 and opened this pull request for review. Could you please take a look and let me know:
Are my explanations clear and technically correct, especially in the key-exercise and mandatory-interpret sections?
Do the solutions meet the expectations for this stage of the course?
Is there anything I could improve in the way I write comments or explain code logic?
Any feedback would be appreciated — thank you for your time!
Best regards,
Sami